Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35282.
Fixes an issue where
serialPort.open()
failed withNetworkError: Failed to open serial port.
.This was happening because we returned
nullptr
fromElectronSerialDelegate::GetPortInfo
:electron/shell/browser/serial/electron_serial_delegate.cc
Lines 91 to 96 in 648c993
and
SerialService::OpenPort
expects thatdelegate->GetInfo
returns non-null in order to succeed.Tested with https://gist.github.com/17afc65be515f3a1aec6256cb69f069d and an Arduino Uno.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
serialPort.open()
failed withNetworkError: Failed to open serial port.
.