Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removes unused import in preload script #35324

Merged
merged 4 commits into from Aug 15, 2022
Merged

docs: removes unused import in preload script #35324

merged 4 commits into from Aug 15, 2022

Conversation

lambainsaan
Copy link
Contributor

notes: Removes unused import which causes issue in preload script of drag and drop tutorial

It fails to run with the error.

VM4 sandbox_bundle:93 Error: module not found: path
    at preloadRequire (VM4 sandbox_bundle:93:1386)
    at <anonymous>:3:14
    at runPreloadScript (VM4 sandbox_bundle:93:2213)
    at Object.<anonymous> (VM4 sandbox_bundle:93:2480)
    at ./lib/sandboxed_renderer/init.ts (VM4 sandbox_bundle:93:2636)
    at __webpack_require__ (VM4 sandbox_bundle:1:170)
    at VM4 sandbox_bundle:1:1242
    at ___electron_webpack_init__ (VM4 sandbox_bundle:1:1320)
    at VM4 sandbox_bundle:160:455

Description of Change

Checklist

Release Notes

Notes: Removes unused import which causes issue in preload script of drag and drop tutorial

@lambainsaan
Remove unused import of path
9668c29 
This import gives out the error in the preload script:

Error: module not found: path
    at preloadRequire
@lambainsaan
Removes unused import in preload script
780317b 
notes: Removes unused import which causes issue in preload script of drag and drop tutorial
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2022
@lambainsaan lambainsaan changed the title Removes unused import in preload script docs: removes unused import in preload script Aug 13, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Aug 13, 2022
@lambainsaan
Remove import path as it is not used in the script
24abac1 
note: Removes import path as it is not used in the script
@lambainsaan
Merge pull request #2 from lambainsaan/lambainsaan-patch-1
fc63736 
Lambainsaan patch 1
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2022
@zcbenz zcbenz added semver/none target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. and removed semver/patch backwards-compatible bug fixes labels Aug 15, 2022
@zcbenz zcbenz merged commit 4cb57ad into electron:main Aug 15, 2022
@welcome
Copy link

welcome bot commented Aug 15, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 15, 2022

Release Notes Persisted

Removes unused import which causes issue in preload script of drag and drop tutorial

This was referenced Aug 15, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 15, 2022

I have automatically backported this PR to "20-x-y", please check out #35333

@trop
Copy link
Contributor

trop bot commented Aug 15, 2022

I have automatically backported this PR to "21-x-y", please check out #35334

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Aug 15, 2022
@commit-lint commit-lint bot mentioned this pull request Oct 26, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@lambainsaan @schetle
docs: removes unused import in preload script (electron#35324)
7bbb283 
* Remove unused import of path

This import gives out the error in the preload script:

Error: module not found: path
    at preloadRequire

* Removes unused import in preload script

notes: Removes unused import which causes issue in preload script of drag and drop tutorial

* Remove import path as it is not used in the script

note: Removes import path as it is not used in the script
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@lambainsaan @khalwa
docs: removes unused import in preload script (electron#35324)
42561bc 
* Remove unused import of path

This import gives out the error in the preload script:

Error: module not found: path
    at preloadRequire

* Removes unused import in preload script

notes: Removes unused import which causes issue in preload script of drag and drop tutorial

* Remove import path as it is not used in the script

note: Removes import path as it is not used in the script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lambainsaan @zcbenz