chore: apply chromium commit 30a32e6 #35370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Aug 23, 2022
zcbenz
changed the title
|
Release Notes Persisted
|
3 tasks
rzhao271
added a commit
to rzhao271/electron
that referenced
this pull request
Oct 10, 2022
5 tasks
rzhao271
added a commit
to rzhao271/electron
that referenced
this pull request
Oct 10, 2022
chore: Apply Chromium commit 30a32e6
5 tasks
deepak1556
pushed a commit
that referenced
this pull request
Oct 11, 2022
jkleinsc
pushed a commit
that referenced
this pull request
Oct 11, 2022
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
chore: Apply Chromium commit 30a32e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Applies Chromium commit 30a32e6 to align Electron's WCO a bit more with Chromium's.
Upstream Chromium bug (see comment 14): https://bugs.chromium.org/p/chromium/issues/detail?id=1316028.
This PR does not fix the WCO spacer colour issue.
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Modified the WCO maximized button style to match Windows 11 more closely.