New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update sandbox renderer defaults for Electron 20 #35379
Merged
VerteDinde
merged 9 commits into
electron:main
from
erickzhao:docs/sandbox-renderer-defaults
Sep 8, 2022
Merged
docs: update sandbox renderer defaults for Electron 20 #35379
VerteDinde
merged 9 commits into
electron:main
from
erickzhao:docs/sandbox-renderer-defaults
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
documentation 📓
semver/patch
backwards-compatible bug fixes
labels
Aug 18, 2022
erickzhao
added
target/20-x-y
target/21-x-y
PR should also be added to the "21-x-y" branch.
labels
Aug 18, 2022
VerteDinde
approved these changes
Aug 18, 2022
nornagon
reviewed
Aug 18, 2022
erickzhao
force-pushed
the
docs/sandbox-renderer-defaults
branch
from
August 19, 2022 17:30
d18a2c5
to
635eb33
Compare
…/ericktron into docs/sandbox-renderer-defaults
nornagon
approved these changes
Sep 7, 2022
VerteDinde
approved these changes
Sep 7, 2022
No Release Notes |
trop bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* docs: update E20 sandbox rendering defaults * docs: update tutorial * simplify paragraph * dont mention context isolation
trop bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* docs: update E20 sandbox rendering defaults * docs: update tutorial * simplify paragraph * dont mention context isolation
I have automatically backported this PR to "21-x-y", please check out #35615 |
trop
bot
removed
the
target/21-x-y
PR should also be added to the "21-x-y" branch.
label
Sep 8, 2022
I have automatically backported this PR to "20-x-y", please check out #35616 |
trop
bot
added
merged/21-x-y
PR was merged to the "21-x-y" branch.
and removed
in-flight/21-x-y
labels
Sep 13, 2022
jkleinsc
pushed a commit
that referenced
this pull request
Sep 13, 2022
docs: update sandbox renderer defaults for Electron 20 (#35379) * docs: update E20 sandbox rendering defaults * docs: update tutorial * simplify paragraph * dont mention context isolation Co-authored-by: Erick Zhao <erick@hotmail.ca>
jkleinsc
pushed a commit
that referenced
this pull request
Sep 13, 2022
docs: update sandbox renderer defaults for Electron 20 (#35379) * docs: update E20 sandbox rendering defaults * docs: update tutorial * simplify paragraph * dont mention context isolation Co-authored-by: Erick Zhao <erick@hotmail.ca>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* docs: update E20 sandbox rendering defaults * docs: update tutorial * simplify paragraph * dont mention context isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation 📓
merged/21-x-y
PR was merged to the "21-x-y" branch.
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#35125 landed in
20-x-y
and changed the default renderer sandbox behaviour totrue
.This PR updates both the Process Sandboxing and the Tutorial docs to reflect this change.
cc @electron/wg-ecosystem, @nornagon
Checklist
Release Notes
Notes: none