Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sandbox renderer defaults for Electron 20 #35379

Merged
merged 9 commits into from Sep 8, 2022

Conversation

erickzhao
Copy link
Member

Description of Change

#35125 landed in 20-x-y and changed the default renderer sandbox behaviour to true.

This PR updates both the Process Sandboxing and the Tutorial docs to reflect this change.

cc @electron/wg-ecosystem, @nornagon

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours documentation 📓 semver/patch backwards-compatible bug fixes labels Aug 18, 2022
@erickzhao erickzhao added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 18, 2022
@erickzhao erickzhao requested a review from a team August 18, 2022 20:30
docs/tutorial/sandbox.md Outdated Show resolved Hide resolved
docs/tutorial/sandbox.md Outdated Show resolved Hide resolved
docs/tutorial/sandbox.md Outdated Show resolved Hide resolved
docs/tutorial/sandbox.md Outdated Show resolved Hide resolved
docs/tutorial/sandbox.md Show resolved Hide resolved
docs/tutorial/tutorial-3-preload.md Show resolved Hide resolved
@erickzhao erickzhao force-pushed the docs/sandbox-renderer-defaults branch from d18a2c5 to 635eb33 Compare August 19, 2022 17:30
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2022
@VerteDinde VerteDinde merged commit 34cb360 into electron:main Sep 8, 2022
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2022

No Release Notes

trop bot pushed a commit that referenced this pull request Sep 8, 2022
* docs: update E20 sandbox rendering defaults

* docs: update tutorial

* simplify paragraph

* dont mention context isolation
trop bot pushed a commit that referenced this pull request Sep 8, 2022
* docs: update E20 sandbox rendering defaults

* docs: update tutorial

* simplify paragraph

* dont mention context isolation
@trop
Copy link
Contributor

trop bot commented Sep 8, 2022

I have automatically backported this PR to "21-x-y", please check out #35615

@trop trop bot added the in-flight/21-x-y label Sep 8, 2022
@trop trop bot removed the target/21-x-y PR should also be added to the "21-x-y" branch. label Sep 8, 2022
@trop
Copy link
Contributor

trop bot commented Sep 8, 2022

I have automatically backported this PR to "20-x-y", please check out #35616

@erickzhao erickzhao deleted the docs/sandbox-renderer-defaults branch September 8, 2022 20:29
@trop trop bot added merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/21-x-y labels Sep 13, 2022
jkleinsc pushed a commit that referenced this pull request Sep 13, 2022
docs: update sandbox renderer defaults for Electron 20 (#35379)

* docs: update E20 sandbox rendering defaults

* docs: update tutorial

* simplify paragraph

* dont mention context isolation

Co-authored-by: Erick Zhao <erick@hotmail.ca>
@trop trop bot added the merged/20-x-y label Sep 13, 2022
jkleinsc pushed a commit that referenced this pull request Sep 13, 2022
docs: update sandbox renderer defaults for Electron 20 (#35379)

* docs: update E20 sandbox rendering defaults

* docs: update tutorial

* simplify paragraph

* dont mention context isolation

Co-authored-by: Erick Zhao <erick@hotmail.ca>
@trop trop bot removed the in-flight/20-x-y label Sep 13, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* docs: update E20 sandbox rendering defaults

* docs: update tutorial

* simplify paragraph

* dont mention context isolation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants