fix: crash when switching origins with emulation settings set #35466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
deepak1556
approved these changes
Aug 26, 2022
zcbenz
approved these changes
Aug 29, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "21-x-y", please check out #35488 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35389.
When we force change origins, our debugger class (a subclass of
content::DevToolsAgentHostClient) isn't aware of those changes unless we hookRenderFrameHostChanged. If we don't do this, some navigation lifecycle events {loadingFinished, dataReceived} emitted by the renderer are lost. We disconnect and reconnect the webcontents to theDevToolsAgentHostto prevent this from happening.As of CL:3758294. this results in a DCHECK, since
DevToolsAgentHost::DisconnectWebContentsresults in a call toUpdateDeviceEmulationStateandhost_is nullptr. To fix this, we revert those state update calls to early returns.Upstreamed at CL:3856525
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash when switching origins with emulation settings set.