fix: crash loading non-standard schemes in iframes #35485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-iframe-non-standard-scheme-crash
branch
from
71707fa
to
17c4c86
Compare
VerteDinde
approved these changes
Aug 30, 2022
ckerr
reviewed
Aug 30, 2022
patches/chromium/fix_crash_loading_non-standard_schemes_in_iframes.patch
Outdated
Show resolved
Hide resolved
codebytere
force-pushed
the
fix-iframe-non-standard-scheme-crash
branch
from
17c4c86
to
299c293
Compare
|
Release Notes Persisted
|
This was referenced Aug 31, 2022
|
I have automatically backported this PR to "19-x-y", please check out #35515 |
|
I have automatically backported this PR to "20-x-y", please check out #35516 |
|
I have automatically backported this PR to "21-x-y", please check out #35517 |
trop
bot
removed
target/20-x-y
target/21-x-y
|
Thank you for doing this! |
trop
bot
added
merged/21-x-y
|
Update: I'm still finding (in Electron 21.2.0) that loading a PDF in an iFrame fails to display the PDF, and loading a PDF in a webview crashes Electron. Here's an Electron Fiddle gist that demonstrates this: https://gist.github.com/george-thomas-hill/c3179e6eddeb1a2715201a20dbf95015 Could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35462.
Closes #28407.
This fixes a crash that occurs when loading non-standard schemes from iframes. This was happening because
ChildProcessSecurityPolicyImpl::CanAccessDataForOrigincontains explicit exceptions to allow built-in non-standard schemes, but does not check for non-standard schemes registered by the embedder.Upstream, CRBUG:1081397 contains several paths forward - here I chose to swap out the
CHECKinnavigation_request.ccfrompolicy->CanAccessDataForOrigintopolicy->CanCommitOriginAndUrl.CL opened at CL:3856266
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that occured when loading non-standard schemes from iframes.