fix: compensate for title bar height when setting bounds on BrowserView
#35495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
3 tasks
trop
bot
added
19-x-y
backport
codebytere
approved these changes
Aug 30, 2022
codebytere
deleted the
trop/19-x-y-bp-fix-compensate-for-title-bar-height-when-setting-bounds-on-browserview--1661788407082
branch
|
Release Notes Persisted
|
|
For Mac OS, This PR will cause view.setBounds({ width, height, x: 0, y: 0}) vertical position incorrectly with missing title bar's height for frame window. "y" cannot use "0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34713
See that PR for details.
Notes: Fixed an issue where part of the BrowserView could be cut off when calling
setBoundson some windows.