Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compensate for title bar height when setting bounds on BrowserView #35502

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 30, 2022

Backport of #34713

See that PR for details.

Notes: Fixed an issue where part of the BrowserView could be cut off when calling setBounds on some windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2022
@trop trop bot requested a review from codebytere August 30, 2022 09:02
@trop trop bot added 21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 30, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2022
@VerteDinde VerteDinde merged commit 38bb3e8 into 21-x-y Sep 22, 2022
@VerteDinde VerteDinde deleted the trop/21-x-y-bp-fix-compensate-for-title-bar-height-when-setting-bounds-on-browserview--1661850166777 branch September 22, 2022 17:01
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2022

Release Notes Persisted

Fixed an issue where part of the BrowserView could be cut off when calling setBounds on some windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants