fix: screen.getCursorScreenPoint() crash on Wayland
#35503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
ckerr
reviewed
Aug 30, 2022
codebytere
force-pushed
the
fix-wayland-crash
branch
2 times, most recently
from
01f4fcc
to
faa7432
Compare
codebytere
force-pushed
the
fix-wayland-crash
branch
from
faa7432
to
bc289b0
Compare
ckerr
approved these changes
Aug 31, 2022
VerteDinde
approved these changes
Sep 1, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "20-x-y" cleanly; |
|
I have automatically backported this PR to "21-x-y", please check out #35575 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: screen.getCursorScreenPoint() crash on Wayland
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35471.
Fixes an issue where
screen.getCursorScreenPoint()crashed on Wayland when it was called before aBrowserWindowhad been created. This happened becuase the Wayland implementation requires it. To fix this, we throw an error if a user attempts to call it before creating aBrowserWindow.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
screen.getCursorScreenPoint()crashed on Wayland when it was called before aBrowserWindowhad been created.