refactor: BrowserView is owned by a BaseWindow #35511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Aug 31, 2022
|
Release Notes Persisted
|
kyrylo-hrechykhin
pushed a commit
to kyrylo-hrechykhin/electron
that referenced
this pull request
Sep 1, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This changes the owner_window of a BrowserView from NativeWindow to
BaseWindow, and makes
getBrowserViews()always in sync with the browser viewsin a window, even if they are reparented.
Checklist
npm testpassesRelease Notes
Notes: Fixed
win.getBrowserViews()not being updated when a BrowserView was moved to a different window.