chore: make macOS spellchecker fns formal no-ops #35514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
deepak1556
approved these changes
Aug 31, 2022
ckerr
reviewed
Aug 31, 2022
codebytere
force-pushed
the
spellchecker-actually-noop
branch
from
85e7191
to
c41dfd9
Compare
jkleinsc
approved these changes
Sep 14, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
I was unable to backport this PR to "20-x-y" cleanly; |
|
I have automatically backported this PR to "21-x-y", please check out #35679 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: make macOS spellchecker fns formal no-ops * docs: correct no-op note * test: add no-op specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35508.
Formally make
session.setSpellCheckerLanguages()andsession.setSpellCheckerDictionaryDownloadURL()no-ops on macOS. macOS uses system spellchecking functionality so those functions would not have their intended effect, but could still throw errors if called with an unsupported language.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where some spellcheck functionality would incorrectly throw errors on macOS.