Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow docking DevTools with WCO #35754

Merged
merged 1 commit into from Sep 22, 2022
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Close #35715.

Refactor #35209 to default the devtools position to detach rather than forcing it unilaterally.

Checklist

Release Notes

Notes: Fixed an issue where DevTools could not be docked with Windows Control Overlay enabled.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 21, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2022
@codebytere codebytere changed the title fix: allow for docking devtools with WCO fix: allow for DevTools with WCO Sep 21, 2022
@codebytere codebytere changed the title fix: allow for DevTools with WCO fix: allow docking DevTools with WCO Sep 21, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2022
@codebytere codebytere merged commit eb3262c into main Sep 22, 2022
@codebytere codebytere deleted the devtools-dock-sometimes branch September 22, 2022 08:44
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2022

Release Notes Persisted

Fixed an issue where DevTools could not be docked with Windows Control Overlay enabled.

@trop
Copy link
Contributor

trop bot commented Sep 22, 2022

I have automatically backported this PR to "19-x-y", please check out #35763

@trop
Copy link
Contributor

trop bot commented Sep 22, 2022

I have automatically backported this PR to "20-x-y", please check out #35764

@trop
Copy link
Contributor

trop bot commented Sep 22, 2022

I have automatically backported this PR to "21-x-y", please check out #35765

@trop trop bot added in-flight/21-x-y and removed target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 22, 2022
@KrisanaSangduen
Copy link

เป้าหมาย/21-xy หมายถึงอะไร

@trop trop bot added the merged/20-x-y label Sep 23, 2022
@trop trop bot added merged/21-x-y PR was merged to the "21-x-y" branch. merged/19-x-y and removed in-flight/20-x-y labels Sep 23, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
fix: allow for docking devtools with WCO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow for opening docked DevTools, even if WCO is enabled
3 participants