Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle an electron.d.ts file in a custom build #35823

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 26, 2022

Backport of #33979

See that PR for details.

Notes: Fixed: If a custom Electron build contains an electron.d.ts file, it is now being used.

* Handle an electron.d.ts file in a custom build

* Fix linter issues

Co-authored-by: Felix Rieseberg <felixr@stripe.com>
@trop trop bot requested a review from a team as a code owner September 26, 2022 18:40
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 26, 2022
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 3c73ea5 into 20-x-y Sep 26, 2022
@jkleinsc jkleinsc deleted the trop/20-x-y-bp-fix-handle-an-electron-d-ts-file-in-a-custom-build-1664217591228 branch September 26, 2022 21:41
@release-clerk
Copy link

release-clerk bot commented Sep 26, 2022

Release Notes Persisted

Fixed: If a custom Electron build contains an electron.d.ts file, it is now being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants