Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: cherry-pick eef098d1c7d5 from webrtc #36264

Merged

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Nov 7, 2022

Reverts #36216

Even though the WebRTC unit tests didn't spot any regression, MS Teams integration testing found crashes caused by this fix. Chromium also did not backport it to LTS.

Notes: Reverted fix for chromium:1361612 due to stability issues.

@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 21-x-y labels Nov 7, 2022
@ppontes ppontes requested review from a team as code owners November 7, 2022 09:05
@ppontes ppontes changed the title chore: Revert "chore: cherry-pick eef098d1c7d5 from webrtc" revert: chore: cherry-pick eef098d1c7d5 from webrtc Nov 8, 2022
@ppontes ppontes changed the title revert: chore: cherry-pick eef098d1c7d5 from webrtc revert: cherry-pick eef098d1c7d5 from webrtc Nov 8, 2022
@ppontes ppontes force-pushed the revert-36216-cherry-pick/21-x-y/webrtc/eef098d1c7d5 branch from e6a03b2 to 0dd76b8 Compare November 8, 2022 22:47
@jkleinsc jkleinsc merged commit 801cbe2 into 21-x-y Nov 9, 2022
@jkleinsc jkleinsc deleted the revert-36216-cherry-pick/21-x-y/webrtc/eef098d1c7d5 branch November 9, 2022 15:51
@release-clerk
Copy link

release-clerk bot commented Nov 9, 2022

Release Notes Persisted

Reverted fix for chromium:1361612 due to stability issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants