Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 177e8bcd3584 from v8 #36303

Merged
merged 2 commits into from Nov 14, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Nov 10, 2022

Merged: [compiler] fix bug in inlining of Array.At

The inlined version of Array.At was only checking the kind of the
maps, rather than the maps themselves. When the feedback was
containing an array map that "supports_fast_array_iteration", then its
kind was added to the list of supported kinds. If this Array.at was
later called with a non-array map with the same kind, then the object
would be wrongly treated as an array.

This is now fixed: inlining Array.at checks the maps directly rather
than only their kinds.

Bug: chromium:1377775
(cherry picked from commit 0ce27310674150b46605c1e226b8f1a2503bac8c)

Change-Id: I2398f2f7a1ea37808962ba5eb3d1fe00a54fd614
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3990747
Commit-Queue: Darius Mercadier dmercadier@chromium.org
Reviewed-by: Tobias Tebbi tebbi@chromium.org
Cr-Commit-Position: refs/branch-heads/10.6@{#49}
Cr-Branched-From: 41bc7435693fbce8ef86753cd9239e30550a3e2d-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b929ce7746409201d77f44048f3e9529b40-refs/heads/main@{#82548}

Notes: Security: backported fix for 1377775.

@ppontes ppontes requested review from a team as code owners November 10, 2022 01:12
@ppontes ppontes added 20-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Nov 10, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Nov 10, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes and removed semver/patch backwards-compatible bug fixes labels Nov 10, 2022
@ppontes ppontes force-pushed the cherry-pick/20-x-y/v8/177e8bcd3584 branch from 1b2f23c to 161158c Compare November 11, 2022 17:41
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes and removed semver/patch backwards-compatible bug fixes labels Nov 14, 2022
@MarshallOfSound MarshallOfSound merged commit b0bd900 into 20-x-y Nov 14, 2022
@MarshallOfSound MarshallOfSound deleted the cherry-pick/20-x-y/v8/177e8bcd3584 branch November 14, 2022 08:16
@release-clerk
Copy link

release-clerk bot commented Nov 14, 2022

Release Notes Persisted

Security: backported fix for 1377775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants