chore: compile addons with --gnu++17 #36369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
semver/patch
electron-cation
bot
added
new-pr 🌱
miniak
approved these changes
Nov 16, 2022
deepak1556
force-pushed
the
robo/fix_gypi_headers
branch
from
469bac7
to
be8d651
Compare
|
Release Notes Persisted
|
This was referenced Nov 17, 2022
|
I have automatically backported this PR to "20-x-y", please check out #36382 |
|
I have automatically backported this PR to "21-x-y", please check out #36383 |
trop
bot
added
in-flight/21-x-y
merged/21-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With Electron 20, V8 uses C++17 features. We updated userland build tools to provide the required compile time flag electron/rebuild#1022. But instead the headers we ship should reflect this change by default similar to Nodejs, refs nodejs/node#38807.
mainbranch already has this change since we updated to Nodejs v18Release Notes
Notes: Update
common.gypifor native modules to support C++17 features in V8