feat: Add BrowserWindow option to hide window in Mission Control (macOS) #36390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
4 tasks
trop
bot
added
22-x-y
backport
VerteDinde
approved these changes
Dec 1, 2022
…OS) (#36092) * feat: Add BrowserWindow option to ignore Mission Control (macOS) * There are many circumstances when app developers may want to hide their windows from mission control. E.g., full screen overlays, small helper windows, dialogs, etc. * This PR adds the functionality, docs, and tests. * chore:Rename variables * Update shell/browser/native_window_mac.h Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com> Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Brad Carter <16466430+carterbs@users.noreply.github.com>
jkleinsc
force-pushed
the
trop/22-x-y-bp-feat-add-browserwindow-option-to-hide-window-in-mission-control-macos--1668738797369
branch
from
41f0c5d
to
10a8c18
Compare
deepak1556
reviewed
Jan 26, 2023
| @@ -192,6 +192,7 @@ It creates a new `BrowserWindow` with native properties as set by the `options`. | |||
| macOS. Default is `false`. | |||
| * `skipTaskbar` boolean (optional) _macOS_ _Windows_ - Whether to show the window in taskbar. | |||
| Default is `false`. | |||
| * `hiddenInMissionControl` boolean (optional) _macOS_ - Whether window should be hidden when the user toggles into mission control. | |||
There was a problem hiding this comment.
Default value is not mentioned here.
There was a problem hiding this comment.
The original PR did not have it, probably better to be fixed in separate PR.
zcbenz
approved these changes
Jan 26, 2023
codebytere
deleted the
trop/22-x-y-bp-feat-add-browserwindow-option-to-hide-window-in-mission-control-macos--1668738797369
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36092
See that PR for details.
Notes:
setHiddenInMissionControlAPI to allow developers to opt out of mission control on macOS.