Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document outlivesOpener option in window open handler #36486

Merged
merged 2 commits into from Nov 30, 2022
Merged

docs: document outlivesOpener option in window open handler #36486

merged 2 commits into from Nov 30, 2022

Conversation

nornagon
Copy link
Member

This was added in #31314 but wasn't
documented in setWindowOpenHandler's docs, only in the window.open docs.

Notes: none

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Nov 29, 2022
@electron-cation electron-cation bot added documentation 📓 new-pr 🌱 PR opened in the last 24 hours labels Nov 29, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 30, 2022
@nornagon nornagon merged commit 835e248 into main Nov 30, 2022
@nornagon nornagon deleted the doc-outlives-opener branch November 30, 2022 23:20
@release-clerk
Copy link

release-clerk bot commented Nov 30, 2022

No Release Notes

This was referenced Nov 30, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 30, 2022

I have automatically backported this PR to "21-x-y", please check out #36507

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Nov 30, 2022
@trop
Copy link
Contributor

trop bot commented Nov 30, 2022

I have automatically backported this PR to "22-x-y", please check out #36508

@trop
Copy link
Contributor

trop bot commented Nov 30, 2022

I have automatically backported this PR to "23-x-y", please check out #36509

@trop trop bot added in-flight/22-x-y merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/21-x-y labels Nov 30, 2022
@trop trop bot removed the in-flight/23-x-y label Dec 5, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
docs: document outlivesOpener option in window open handler (electron…
0d1a258 
…#36486)
@commit-lint commit-lint bot mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @VerteDinde