Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixup mksnapshot args on linux #36534

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 1, 2022

Backport of #36531

See that PR for details.

Notes: Removed unneeded --turbo-profiling-input argument from mksnapshot_args for Linux mksnapshot zips.

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot requested a review from jkleinsc December 1, 2022 19:13
@trop trop bot mentioned this pull request Dec 1, 2022
2 tasks
@trop trop bot added 23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 1, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Dec 2, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 8635029 into 23-x-y Dec 2, 2022
@jkleinsc jkleinsc deleted the trop/23-x-y-bp-build-fixup-mksnapshot-args-on-linux-1669921988693 branch December 2, 2022 00:27
@release-clerk
Copy link

release-clerk bot commented Dec 2, 2022

Release Notes Persisted

Removed unneeded --turbo-profiling-input argument from mksnapshot_args for Linux mksnapshot zips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants