fix: use the process cache to reduce the memory for asar file #36598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The memory leaks at /lib/asar/fs-wrapper.ts,
const cachedArchives = new Map<string, NodeJS.AsarArchive>()
Whenever a new worker is created, it will have an instance of this map. The contents of this map will not be cleaned up immediately.And there is a process-level cache at /shell/common/asar/asar_util.cc,
static base::NoDestructor<ArchiveMap> s_archive_map
In summary, I decide to use this process-level cache to save the asar cache instead of creating a new one for each worker
Checklist
npm test
passesRelease Notes
Notes: use the process cache to reduce the memory for asar file