chore: cherry-pick 09ae62b from node #36626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
20-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
VerteDinde
approved these changes
Dec 12, 2022
|
Looks like the patch failed to apply; I'll take a look this week |
nornagon
approved these changes
Dec 13, 2022
|
Release Notes Persisted
|
3 tasks
hyazinthh
added a commit
to aardvark-community/aardium
that referenced
this pull request
Nov 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-api: handle no support for external buffers
Refs: #35801
Refs: nodejs/abi-stable-node#441
Electron recently dropped support for external
buffers. Provide a way for addon authors to:
avoid using them if they want the broadest compatibility.
to check if external buffers are supported and either
use them or not based on the return code.
Signed-off-by: Michael Dawson mdawson@devrus.com
PR-URL: nodejs/node#45181
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
Notes: Added node-api: handle no support for external buffers.