fix: strip branded binaries #36656
Merged
fix: strip branded binaries #36656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
When creating branded release builds and using scripts/strip-binaries.py on Linux, the final artifacts end up unstripped due to the static set of binaries considered for stripping. With this patch the name of the electron binary is taken from the BRANDING.json `project_name` key. Signed-off-by: Robert Günzler <r@gnzler.io> Co-authored-by: Robert Günzler <r@gnzler.io>
trop
bot
added
23-x-y
backport
jkleinsc
approved these changes
Dec 14, 2022
jkleinsc
deleted the
trop/23-x-y-bp-fix-strip-branded-binaries-1670968985222
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36641
See that PR for details.
Notes: Fix binary stripping for branded release builds on Linux