Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL WindowButtonsProxy buttons #36852

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 10, 2023

Backport of #36839

See that PR for details.

Notes: Fixed an RTL issue that could happen in some locales when calling BrowserWindow.setTrafficLightPosition() on macOS.

trop bot and others added 2 commits January 10, 2023 11:19
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere January 10, 2023 11:20
@trop trop bot mentioned this pull request Jan 10, 2023
3 tasks
@trop trop bot added 21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 10, 2023
@codebytere codebytere merged commit 54c11f7 into 21-x-y Jan 11, 2023
@codebytere codebytere deleted the trop/21-x-y-bp-fix-rtl-windowbuttonsproxy-buttons-1673349569899 branch January 11, 2023 10:56
@release-clerk
Copy link

release-clerk bot commented Jan 11, 2023

Release Notes Persisted

Fixed an RTL issue that could happen in some locales when calling BrowserWindow.setTrafficLightPosition() on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants