fix: falsy transparent shouldn't affect webContents background #36914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
dsanders11
force-pushed
the
fix-36538
branch
3 times, most recently
from
d20e160
to
257490e
Compare
dsanders11
added
target/23-x-y
electron-cation
bot
added
new-pr 🌱
codebytere
approved these changes
Apr 27, 2023
VerteDinde
approved these changes
May 2, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "24-x-y" cleanly; |
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
needs-manual-bp/23-x-y
and removed
target/24-x-y
|
/trop run backport-to 25-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/25-x-y
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
May 3, 2023
|
@dsanders11 has manually backported this PR to "25-x-y", please check out #38157 |
|
@dsanders11 has manually backported this PR to "24-x-y", please check out #38158 |
|
@dsanders11 has manually backported this PR to "23-x-y", please check out #38159 |
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
May 3, 2023
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
May 3, 2023
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
May 3, 2023
trop
bot
added
merged/24-x-y
codebytere
pushed a commit
that referenced
this pull request
May 3, 2023
fix: falsy transparent shouldn't affect webContents background (#36914)
trop
bot
added
merged/25-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #37737.
Fixes #36538.
Falsy values for
transparentwere incorrectly setting thewebContentsbackground to be transparent. This was only noticeable in certain situations, since setting a background color for the page would override the transparency. It would affect child windows without any explicit setting oftransparentdue to the usage of an empty object for browser window options in those cases which led to thetransparentkey being set with a value ofundefined, triggering the bug.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where default background color for windows might be incorrect