fix: webview background color on reload #36920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
requested review from
deepak1556,
samuelmaddock and
MarshallOfSound
deepak1556
reviewed
Jan 16, 2023
codebytere
force-pushed
the
fix-webview-bg-color
branch
from
63270ce
to
0ed9486
Compare
deepak1556
approved these changes
Jan 18, 2023
|
Release Notes Persisted
|
This was referenced Jan 18, 2023
|
I have automatically backported this PR to "23-x-y", please check out #36938 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "21-x-y", please check out #36939 |
|
I have automatically backported this PR to "22-x-y", please check out #36940 |
trop
bot
added
in-flight/21-x-y
merged/22-x-y
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #36417.
Fixes an issue where webview background color would not correctly be set on reload. This was happening as a result of #33435, where I fixed an issue with missing transparency but made it such that when
webPreferenceshad no color stored the initial background color would be set to white. Instead, we need to explicitly set guest webContents background color to transparent whenwebPreferenceshas no color stored.Tested with https://gist.github.com/PerfectPan/100900b7758293b8f72b23d0babdb1cc and confirmed not to regress #33374
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
webViews could have an incorrect initial background color following reloads.