Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated deep link docs #37032

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 26, 2023

Backport of #36952

See that PR for details.

Notes: In deep link docs the windows specific code also contains macOS/Linux code which is confusing.

trop bot and others added 5 commits January 26, 2023 07:20
Co-authored-by: Himanshu Patil <himanshupatil744@gmail.com>
Co-authored-by: Himanshu Patil <himanshupatil744@gmail.com>
Co-authored-by: Himanshu Patil <himanshupatil744@gmail.com>
Co-authored-by: Himanshu Patil <himanshupatil744@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

Co-authored-by: Himanshu Patil <himanshupatil744@gmail.com>
@trop trop bot mentioned this pull request Jan 26, 2023
5 tasks
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 26, 2023
@codebytere codebytere merged commit 21082ae into 22-x-y Jan 30, 2023
@codebytere codebytere deleted the trop/22-x-y-bp-docs-updated-deep-link-docs-1674717630115 branch January 30, 2023 09:58
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2023

Release Notes Persisted

In deep link docs the windows specific code also contains macOS/Linux code which is confusing.

@@ -23,6 +23,8 @@ if (!gotTheLock) {
if (mainWindow.isMinimized()) mainWindow.restore()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants