feat: add logUsage to shell.openExternal() options #37139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/shell-open-external-log-usage
branch
4 times, most recently
from
3f61277
to
2896c0b
Compare
miniak
force-pushed
the
miniak/shell-open-external-log-usage
branch
from
2896c0b
to
05ff309
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
|
/trop run backport-to 24-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "24-x-y", please check out #37291 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Milan Burda <miburda@microsoft.com>
trop
bot
added
merged/24-x-y
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow passing the
SEE_MASK_FLAG_LOG_USAGEflag toShellExecuteExon Windows.Checklist
npm testpassesRelease Notes
Notes: Added
logUsagetoshell.openExternal()options, which allows passing theSEE_MASK_FLAG_LOG_USAGEflag toShellExecuteExon Windows.