Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename built-in modules to bindings to match naming update in node #37182

Merged
merged 1 commit into from Feb 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/development/creating-api.md
Expand Up @@ -138,7 +138,7 @@ interface Process {
At the very bottom of your `api_name.cc` file:

```cpp title='api_name.cc'
NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_{api_name},Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_{api_name},Initialize)
```

In your [`shell/common/node_bindings.cc`](https://github.com/electron/electron/blob/main/shell/common/node_bindings.cc) file, add your node binding name to Electron's built-in modules.
Expand Down
4 changes: 2 additions & 2 deletions shell/app/node_main.cc
Expand Up @@ -146,8 +146,8 @@ int NodeMain(int argc, char* argv[]) {
feature_list->InitializeFromCommandLine("", "");
base::FeatureList::SetInstance(std::move(feature_list));

// Explicitly register electron's builtin modules.
NodeBindings::RegisterBuiltinModules();
// Explicitly register electron's builtin bindings.
NodeBindings::RegisterBuiltinBindings();

// Parse and set Node.js cli flags.
int flags_exit_code = SetNodeCliFlags();
Expand Down
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_app.cc
Expand Up @@ -1865,4 +1865,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_app, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_app, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_auto_updater.cc
Expand Up @@ -149,4 +149,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_auto_updater, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_auto_updater, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_base_window.cc
Expand Up @@ -1359,4 +1359,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_base_window, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_base_window, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_browser_view.cc
Expand Up @@ -221,4 +221,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_browser_view, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_browser_view, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_browser_window.cc
Expand Up @@ -488,4 +488,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_window, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_window, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_content_tracing.cc
Expand Up @@ -178,4 +178,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_content_tracing, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_content_tracing, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_crash_reporter.cc
Expand Up @@ -279,4 +279,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_crash_reporter, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_crash_reporter, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_desktop_capturer.cc
Expand Up @@ -356,4 +356,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_desktop_capturer, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_desktop_capturer, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_dialog.cc
Expand Up @@ -105,4 +105,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_dialog, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_dialog, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_event.cc
Expand Up @@ -25,4 +25,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_event, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_event, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_event_emitter.cc
Expand Up @@ -46,4 +46,4 @@ v8::Local<v8::Object> GetEventEmitterPrototype(v8::Isolate* isolate) {

} // namespace electron

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_event_emitter, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_event_emitter, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_global_shortcut.cc
Expand Up @@ -195,4 +195,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_global_shortcut, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_global_shortcut, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_in_app_purchase.cc
Expand Up @@ -230,4 +230,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_in_app_purchase, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_in_app_purchase, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_menu.cc
Expand Up @@ -321,4 +321,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_menu, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_menu, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_native_theme.cc
Expand Up @@ -170,4 +170,4 @@ bool Converter<ui::NativeTheme::ThemeSource>::FromV8(

} // namespace gin

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_native_theme, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_native_theme, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_net.cc
Expand Up @@ -58,4 +58,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_net, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_net, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_notification.cc
Expand Up @@ -299,4 +299,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_notification, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_notification, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_power_monitor.cc
Expand Up @@ -154,4 +154,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_power_monitor, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_power_monitor, Initialize)
4 changes: 2 additions & 2 deletions shell/browser/api/electron_api_power_save_blocker.cc
Expand Up @@ -139,5 +139,5 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_power_save_blocker,
Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_power_save_blocker,
Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_printing.cc
Expand Up @@ -111,4 +111,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_printing, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_printing, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_protocol.cc
Expand Up @@ -339,4 +339,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_protocol, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_protocol, Initialize)
4 changes: 2 additions & 2 deletions shell/browser/api/electron_api_push_notifications.cc
Expand Up @@ -73,5 +73,5 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_push_notifications,
Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_push_notifications,
Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_safe_storage.cc
Expand Up @@ -131,4 +131,4 @@ void Initialize(v8::Local<v8::Object> exports,
dict.SetMethod("decryptString", &electron::safestorage::DecryptString);
}

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_safe_storage, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_safe_storage, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_screen.cc
Expand Up @@ -196,4 +196,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_screen, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_screen, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_session.cc
Expand Up @@ -1313,4 +1313,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_session, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_session, Initialize)
4 changes: 2 additions & 2 deletions shell/browser/api/electron_api_system_preferences.cc
Expand Up @@ -132,5 +132,5 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_system_preferences,
Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_system_preferences,
Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_tray.cc
Expand Up @@ -436,4 +436,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_tray, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_tray, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_utility_process.cc
Expand Up @@ -417,4 +417,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_utility_process, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_utility_process, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_view.cc
Expand Up @@ -76,4 +76,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_view, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_view, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_web_contents.cc
Expand Up @@ -4244,4 +4244,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_web_contents, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_web_contents, Initialize)
3 changes: 2 additions & 1 deletion shell/browser/api/electron_api_web_contents_view.cc
Expand Up @@ -131,4 +131,5 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_web_contents_view, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_web_contents_view,
Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_web_frame_main.cc
Expand Up @@ -459,4 +459,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_web_frame_main, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_web_frame_main, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_web_view_manager.cc
Expand Up @@ -47,4 +47,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_web_view_manager, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_web_view_manager, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/message_port.cc
Expand Up @@ -293,4 +293,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_message_port, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_message_port, Initialize)
2 changes: 1 addition & 1 deletion shell/browser/api/views/electron_api_image_view.cc
Expand Up @@ -56,4 +56,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_browser_image_view, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_image_view, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/crashpad_support.cc
Expand Up @@ -36,4 +36,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_crashpad_support, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_crashpad_support, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_asar.cc
Expand Up @@ -246,4 +246,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_asar, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_asar, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_clipboard.cc
Expand Up @@ -291,4 +291,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_clipboard, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_clipboard, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_command_line.cc
Expand Up @@ -67,4 +67,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_command_line, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_command_line, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_environment.cc
Expand Up @@ -42,4 +42,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_environment, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_environment, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_native_image.cc
Expand Up @@ -641,4 +641,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_native_image, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_native_image, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_shell.cc
Expand Up @@ -186,4 +186,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_shell, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_shell, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_testing.cc
Expand Up @@ -44,5 +44,5 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_testing, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_testing, Initialize)
#endif
2 changes: 1 addition & 1 deletion shell/common/api/electron_api_v8_util.cc
Expand Up @@ -138,4 +138,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_v8_util, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_v8_util, Initialize)
2 changes: 1 addition & 1 deletion shell/common/api/features.cc
Expand Up @@ -84,4 +84,4 @@ void Initialize(v8::Local<v8::Object> exports,

} // namespace

NODE_LINKED_MODULE_CONTEXT_AWARE(electron_common_features, Initialize)
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_features, Initialize)