Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cookies filter secure invalid #37203

Merged
merged 9 commits into from Feb 13, 2023
Merged

fix: cookies filter secure invalid #37203

merged 9 commits into from Feb 13, 2023

Conversation

BlackHole1
Copy link
Member

@BlackHole1 BlackHole1 commented Feb 9, 2023 •
edited

Description of Change

image

gist: https://gist.github.com/6d2ba80a835a75f90f385a2f4664a6a0

This is a simple judgment condition error that just needs to be corrected to the correct judgment condition.

Checklist

Release Notes

Notes: Fixed an incorrect result returned when using secure as a cookies filter.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2023
codebytere
codebytere requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please describe the issue in more detail as well as properly fill out the PR template? Additionally, we should have some tests for this.

@BlackHole1 BlackHole1 changed the title fix: cookies filter secure and session invalid fix: cookies filter secure invalid Feb 9, 2023
@BlackHole1
Copy link
Member Author

@codebytere Description updated and already add tests.

deepak1556
deepak1556 approved these changes Feb 9, 2023
View reviewed changes
shell/browser/api/electron_api_cookies.cc Outdated Show resolved Hide resolved
@deepak1556 deepak1556 added the semver/patch backwards-compatible bug fixes label Feb 9, 2023
@deepak1556
Copy link
Member

@BlackHole1 can you update the Notes: section with user facing release note since this is a bug fix.

@deepak1556 deepak1556 added target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 9, 2023
@BlackHole1
Copy link
Member Author

@deepak1556 Done. I updated the notes description.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2023
@codebytere codebytere merged commit 8b3e498 into electron:main Feb 13, 2023
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2023

Release Notes Persisted

Fixed an incorrect result returned when using secure as a cookies filter.

This was referenced Feb 13, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 13, 2023

I have automatically backported this PR to "24-x-y", please check out #37246

@trop trop bot mentioned this pull request Feb 13, 2023
Merged
@trop trop bot removed the target/24-x-y PR should also be added to the "24-x-y" branch. label Feb 13, 2023
@trop
Copy link
Contributor

trop bot commented Feb 13, 2023

I have automatically backported this PR to "22-x-y", please check out #37247

@trop
Copy link
Contributor

trop bot commented Feb 13, 2023

I have automatically backported this PR to "23-x-y", please check out #37248

@trop trop bot added in-flight/22-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Feb 13, 2023
@BlackHole1 BlackHole1 deleted the fix-cookies-filter branch February 14, 2023 03:01
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/22-x-y labels Feb 15, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@BlackHole1 @khalwa
fix: cookies filter secure invalid (electron#37203)
8fe2028
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Feb 27, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@BlackHole1 @gecko19
fix: cookies filter secure invalid (electron#37203)
29bdf5d
@commit-lint commit-lint bot mentioned this pull request May 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BlackHole1 @deepak1556 @zcbenz @codebytere