Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore original draggable regions behavior pre-35603 #37372

Closed
wants to merge 3 commits into from

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Feb 21, 2023

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2023
@MarshallOfSound MarshallOfSound added target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. semver/patch backwards-compatible bug fixes labels Feb 21, 2023
@nornagon
Copy link
Member

reverting not necessary; discovered that new impl is correct.

tldr: previously, -webkit-app-region: no-drag would "shine through" -webkit-app-region: drag. it no longer does. hacks that apps used to work around that bug may now be presenting as bugs, but these should be fixed on the app side.

@nornagon nornagon closed this Feb 21, 2023
@nornagon nornagon deleted the revert-draggable branch February 21, 2023 22:22
@codebytere
Copy link
Member

codebytere commented Feb 22, 2023

@nornagon can you please comment on the open bugs then? there are several:

I'm also not sure I agree this is working as expected - take #37301. In Chromium, it's quite possible to open a context menu in the toolbar:

Screenshot 2023-02-22 at 10 01 42 AM

where i can also drag.

@nornagon
Copy link
Member

@codebytere done. #37137 is a duplicate of an older bug (#32341), that one is gnarly and can't be fixed without some serious hacking in Blink. It's a Chrome bug, not (just) our bug.

#37210 is WAI, the old behavior was buggy.

#37301 is a real bug, I opened #37386 to fix it.

@codebytere
Copy link
Member

ty! is #32341 open as a crbug anywhere? i'd prefer to kick it up there where possible 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants