Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when using vm after
window.open()#37506fix: crash when using vm after
window.open()#37506Changes from all commits
0ff6c2aFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()Check failure on line 180 in spec/guest-window-manager-spec.ts
spec/guest-window-manager-spec.ts#L180
Raw output
++<<<<<<< HEAD + it('can change webPreferences of child windows', (done) => { ++======= + it('does not crash when used in conjunction with the vm module', async () => { + const w = new BrowserWindow({ + show: false, + webPreferences: { + contextIsolation: false, + nodeIntegration: true + } + }); + + await w.loadURL('about:blank'); + + const didCreateWindow = once(w.webContents, 'did-create-window'); + w.webContents.executeJavaScript("window.open('')"); + await didCreateWindow; + + const result = await w.webContents.executeJavaScript(` + const vm = require('node:vm') + const run = () => { + const context = { x: 2 } + vm.createContext(context) + vm.runInContext('x += 40', context) + return context.x + } + run() + `); + + expect(result).to.equal(42); + }); + + it('can change webPreferences of child windows', async () => { ++>>>>>>> fix: crash when using vm after window.open()