Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 86fc0e9bedaf from chromium #37665

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Mar 22, 2023

[M108-LTS] Prevent potential integer overflow in PersistentMemoryAllocator

BUG=1415328

(cherry picked from commit 19de280a0c28065acf2a7e001af5c981698a461c)

Change-Id: I66dcae6a1aacc1310ddd715033b3704c932b9800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4250177
Commit-Queue: Will Harris wfh@chromium.org
Commit-Queue: Alexei Svitkine asvitkine@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1105177}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4279513
Commit-Queue: Zakhar Voit voit@google.com
Owners-Override: Victor-Gabriel Savu vsavu@google.com
Reviewed-by: Victor-Gabriel Savu vsavu@google.com
Cr-Commit-Position: refs/branch-heads/5359@{#1400}
Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933}

Notes: Security: backported fix for 1417317.

@ppontes ppontes requested a review from a team as a code owner March 22, 2023 17:29
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Mar 22, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 22, 2023
@jkleinsc
Copy link
Contributor

Patch has already been merged in via #37669

@jkleinsc jkleinsc closed this Mar 28, 2023
@jkleinsc jkleinsc deleted the cherry-pick/22-x-y/chromium/d202ad3c6aeb branch March 28, 2023 00:50
@ppontes ppontes restored the cherry-pick/22-x-y/chromium/d202ad3c6aeb branch March 28, 2023 09:39
@ppontes ppontes reopened this Mar 28, 2023
@ppontes ppontes marked this pull request as draft March 28, 2023 09:39
@ppontes
Copy link
Member Author

ppontes commented Mar 28, 2023

@jkleinsc, thanks for catching this. There are actually 2 different commits upstream with the same title, which caused this confusion. I'm fixing this here for 22 and will create a new PR for 21 to restore what was removed in 50128ea.

@ppontes ppontes marked this pull request as ready for review March 28, 2023 09:54
@ppontes ppontes marked this pull request as draft March 28, 2023 09:55
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/d202ad3c6aeb branch from 38b4db0 to dde040b Compare March 28, 2023 13:53
@ppontes ppontes changed the title chore: cherry-pick d202ad3c6aeb from chromium chore: cherry-pick 86fc0e9bedaf from chromium Mar 28, 2023
@ppontes ppontes marked this pull request as ready for review March 28, 2023 13:53
@ckerr ckerr requested a review from jkleinsc March 28, 2023 18:06
@jkleinsc jkleinsc merged commit f0685b6 into 22-x-y Apr 18, 2023
@jkleinsc jkleinsc deleted the cherry-pick/22-x-y/chromium/d202ad3c6aeb branch April 18, 2023 01:11
@release-clerk
Copy link

release-clerk bot commented Apr 18, 2023

Release Notes Persisted

Security: backported fix for 1417317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants