Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove workaround for fixed Menu.closePopup issue #37802

Merged
merged 1 commit into from Apr 4, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Apr 3, 2023

Description of Change

Was fixed a while ago in #20114, so remove the workaround on these tests.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@dsanders11 dsanders11 added 24-x-y target/24-x-y PR should also be added to the "24-x-y" branch. and removed 24-x-y labels Apr 3, 2023
@dsanders11 dsanders11 marked this pull request as ready for review April 3, 2023 14:12
@codebytere codebytere merged commit 4c8583c into main Apr 4, 2023
18 checks passed
@codebytere codebytere deleted the menu-closepopup-fixed branch April 4, 2023 08:27
@release-clerk
Copy link

release-clerk bot commented Apr 4, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 4, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Apr 4, 2023
dsanders11 added a commit to dsanders11/electron that referenced this pull request Apr 5, 2023
@trop
Copy link
Contributor

trop bot commented Apr 5, 2023

@dsanders11 has manually backported this PR to "24-x-y", please check out #37846

@trop trop bot added in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch and removed needs-manual-bp/24-x-y in-flight/24-x-y labels Apr 5, 2023
zcbenz pushed a commit that referenced this pull request Apr 6, 2023
test: remove workaround for fixed Menu.closePopup issue (#37802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/24-x-y PR was merged to the "24-x-y" branch semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants