Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: showAboutPanel also on linux #37828

Merged
merged 1 commit into from Apr 6, 2023
Merged

fix: showAboutPanel also on linux #37828

merged 1 commit into from Apr 6, 2023

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Apr 5, 2023 •
edited

Description of Change

Similar to #23681 - role: about doesn't work on Linux, even though docs make it look like it works.

See also #23847 #23851 mifi/lossless-cut#1537

Checklist

Release Notes

Notes: Added about panel for menu role about on Linux as well

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2023
@mifi mifi changed the title showAboutPanel also on linux fix: showAboutPanel also on linux Apr 5, 2023
This was referenced Apr 5, 2023
Closed
Closed
@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Apr 6, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 6, 2023
@jkleinsc jkleinsc merged commit e8c8785 into electron:main Apr 6, 2023
15 of 16 checks passed
@release-clerk
Copy link

release-clerk bot commented Apr 6, 2023

Release Notes Persisted

Added about panel for menu role about on Linux as well

@trop trop bot mentioned this pull request Apr 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Apr 6, 2023

I have automatically backported this PR to "24-x-y", please check out #37872

@trop trop bot mentioned this pull request Apr 6, 2023
Merged
@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Apr 6, 2023
@trop trop bot mentioned this pull request Apr 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Apr 6, 2023

I have automatically backported this PR to "25-x-y", please check out #37873

@trop
Copy link
Contributor

trop bot commented Apr 6, 2023

I have automatically backported this PR to "23-x-y", please check out #37874

@trop trop bot added in-flight/25-x-y in-flight/23-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/25-x-y in-flight/23-x-y labels Apr 6, 2023
@trop trop bot removed the in-flight/24-x-y label Apr 11, 2023
@commit-lint commit-lint bot mentioned this pull request Jun 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mifi @jkleinsc