Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove workaround for fixed Menu.closePopup issue #37846

Merged
merged 1 commit into from
Apr 6, 2023
Merged

test: remove workaround for fixed Menu.closePopup issue #37846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 3 additions & 12 deletions spec/api-menu-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,10 +816,7 @@ describe('Menu module', function () {
it('should emit menu-will-close event', (done) => {
menu.on('menu-will-close', () => { done(); });
menu.popup({ window: w });
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});

it('returns immediately', () => {
Expand Down Expand Up @@ -848,18 +845,12 @@ describe('Menu module', function () {

expect(x).to.equal(100);
expect(y).to.equal(101);
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});

it('works with a given BrowserWindow, no options, and a callback', (done) => {
menu.popup({ window: w, callback: () => done() });
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});

it('prevents menu from getting garbage-collected when popuping', async () => {
Expand Down