feat: session.resolveHost #37847
Merged
feat: session.resolveHost #37847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: session.resolveHost Expose Chromium's host resolution API through the Session object. * Update shell/browser/api/electron_api_session.cc Co-authored-by: Jeremy Rose <nornagon@nornagon.net> * address feedback * fix tests * address feedback * Add options * Update shell/browser/api/electron_api_session.cc Co-authored-by: Cheng Zhao <github@zcbenz.com> * Update shell/browser/net/resolve_host_function.cc Co-authored-by: Cheng Zhao <github@zcbenz.com> * lint * return object * add missing file * fix crash * handle scope * links --------- Co-authored-by: Fedor Indutny <indutny@signal.org> Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Cheng Zhao <github@zcbenz.com>
|
cc @nornagon ? |
trop
bot
added
24-x-y
backport
|
@indutny Thanks for the backport! We have a Releases WG meeting this afternoon we review/approve backport requests, will get this reviewed for you 🙇♀️ |
|
@indutny please copy over the release notes 🙇🏻 |
|
Really appreciate it. Thanks! |
done, sorry! I wasn't sure what the template for the backport PR should look like so I copied it from #37846 😂 |
|
@indutny, if you use $ e backport 37690
// Fix conflicts, `git cherry-pick --continue`
$ git push fork
$ e pr --backport 37690 |
VerteDinde
approved these changes
Apr 6, 2023
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37690.
See that PR for details.
Notes: Introduced
session.resolveHostfor resolving hostnames with Chromium's DNS resolver