Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick d6946b70b431 from chromium #37848

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 5, 2023

[M112] Move the edit commands to an on stack variable

DevTools uses nested event loops and the usage of the class member can
be problematic for iteration because the nested loop can change the
variable's storage causing a UAF.

(cherry picked from commit d9b34f0f3a2d0dd73648eca3ef940fb66806227b)

Bug: 1420510
Change-Id: Ie08a71b60401fa4322cca0cc31062ba64672126a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4355811
Reviewed-by: David Bokan bokan@chromium.org
Commit-Queue: Dave Tapuska dtapuska@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1120123}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369603
Cr-Commit-Position: refs/branch-heads/5615@{#809}
Cr-Branched-From: 9c6408ef696e83a9936b82bbead3d41c93c82ee4-refs/heads/main@{#1109224}

Ref electron/security#307

Notes: Security: backported fix for CVE-2023-1811.

@ppontes ppontes requested a review from a team as a code owner April 5, 2023 22:49
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 5, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 5, 2023
@codebytere codebytere merged commit c875adf into 22-x-y Apr 11, 2023
9 checks passed
@codebytere codebytere deleted the cherry-pick/22-x-y/chromium/d6946b70b431 branch April 11, 2023 19:13
@release-clerk
Copy link

release-clerk bot commented Apr 11, 2023

Release Notes Persisted

Security: backported fix for CVE-2023-1811.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants