feat: net.resolveHost #37853
Merged
feat: net.resolveHost #37853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
target/24-x-y
|
@indutny I went ahead and added backport requests for 24-x-y and 25-x-y, since that's also where the last .net PR was targeted. If that isn't right or you want to backport further, just let me know, I can add/remove as needed 😄 |
|
This sounds good to me. Thanks! |
jkleinsc
approved these changes
May 1, 2023
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/25-x-y
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
and removed
target/24-x-y
codebytere
pushed a commit
that referenced
this pull request
May 2, 2023
Merged
|
@codebytere has manually backported this PR to "25-x-y", please check out #38152 |
Merged
|
@codebytere has manually backported this PR to "24-x-y", please check out #38153 |
trop
bot
added
in-flight/24-x-y
merged/24-x-y
codebytere
added a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
See #37690
This adds
net.resolveHostmethod that usesdefaultSessionto resolve hosts (similar tonet.fetch).cc @nornagon
Checklist
npm testpassesRelease Notes
Notes: Add net.resolveHost that resolves hosts using defaultSession object