fix: broken buttons in PDF viewer #37856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
deepak1556
reviewed
Apr 6, 2023
codebytere
force-pushed
the
fix-pdf-buttons
branch
from
685639d
to
b5aea75
Compare
deepak1556
approved these changes
Apr 6, 2023
zcbenz
approved these changes
Apr 6, 2023
|
Release Notes Persisted
|
This was referenced Apr 11, 2023
|
I have automatically backported this PR to "24-x-y", please check out #37918 |
|
I have automatically backported this PR to "23-x-y", please check out #37919 |
trop
bot
added
in-flight/23-x-y
and removed
target/24-x-y
|
I have automatically backported this PR to "25-x-y", please check out #37920 |
trop
bot
added
in-flight/25-x-y
merged/24-x-y
trop
bot
added
merged/25-x-y
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37842.
Fixes an issue where certain buttons in the PDF viewer didn't work. This was happening because we'd gotten out of sync in
AddStringsForPdfand were missing some values. To fix this more robustly, we should actually be calling the upstream functions inpdf_extension_util.h, which is what this PR does.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where certain buttons in the PDF viewer didn't work.