New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: defaultFontFamily in webPreferences #37863
Conversation
44d4959
to
2b52ed8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this option is rarely used it might worth adding a if (!default_font_family_.empty())
test.
Release Notes Persisted
|
I have automatically backported this PR to "25-x-y", please check out #37967 |
I have automatically backported this PR to "24-x-y", please check out #37968 |
I have automatically backported this PR to "23-x-y", please check out #37969 |
I have automatically backported this PR to "22-x-y", please check out #37970 |
Description of Change
This fix brought to you by
clang-tidy
, which detected the problem:Got broken by the refactors in #30193 (which shipped in v16) and there was no test coverage.
As far as I can tell, though, no one has reported the issue in that time, so that may speak to how used this option is.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue which made defaultFontFamily in webPreferences have no effect