feat: add did-resign-active event on app
#37933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/minor
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
miniak
approved these changes
Apr 11, 2023
|
API LGTM |
deepak1556
approved these changes
Apr 12, 2023
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
|
I have automatically backported this PR to "25-x-y", please check out #38018 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
|
Cheers @codebytere! |
trop
bot
added
merged/25-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37891
This PR adds a new 'did-resign-active' event on
app, which forms a pair with pre-existing event 'did-become-active'. This event is emitted when the app is no longer active and doesn’t have focus. This can be triggered, for example, by clicking on another application or by using the macOS App Switcher to switch to another application.The instigating issue requested exposure of
hidesOnDeactivate- i chose to pursue this route instead because we already have a plethora of BrowserWindow options, and exposing that option is fairly limiting. There are several things a user might want to do upon app deactivation besides hide the app - background work, UI changes, etc. This solves the user's issue while also allowing for a greater range of use cases.Checklist
Release Notes
Notes: Added new 'did-resign-active' event on
app.