fix: swipe event emission on macOS #37946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-swipe-with-event
branch
from
11abb36
to
21d13d8
Compare
zcbenz
approved these changes
Apr 13, 2023
|
Release Notes Persisted
|
This was referenced Apr 13, 2023
|
I have automatically backported this PR to "24-x-y", please check out #37965 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
|
I have automatically backported this PR to "25-x-y", please check out #37966 |
trop
bot
added
in-flight/25-x-y
merged/25-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37628.
Refs #35603
Fixes an issue where the 'swipe' event wasn't being emitted properly on macOS. This happened as a result of #35603, which removed our
OverrideNSWindowContentViewlogic. This logic replacedBridgedContentViewinElectronNSWindowwith our own logic, and enabled our implementation ofswipeWithEventto take precedence. After the removal of that code, theswipeWithEventimplementation inBridgedContentViewwould always be called regardless of our override. Fix this by forcing our implementation to be called instead.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the 'swipe' event wasn't being emitted properly on macOS.