Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f4b66ae451c2 from v8 #37983

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 14, 2023

Merged: [compiler] Prevent constant folding of TypeGuard

TypeGuard are used to prevent operations from floating before a
preceding check, and thus shouldn't be constant-folded.

Bug: chromium:1427388
(cherry picked from commit 867716437273c16dc6ef5bc85b9c18affa1fb242)

Change-Id: Ia334d079707f13974235f8c04ccb468ac16ff794
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4386487
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Commit-Queue: Darius Mercadier dmercadier@chromium.org
Cr-Commit-Position: refs/branch-heads/11.2@{#23}
Cr-Branched-From: 755511a138609ac5939449a8ac615c15603a4454-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1ccefb0f0f1ff8d310578878130dc53d73749-refs/heads/main@{#86014}

Notes: Security: backported fix for 1427388.

@ppontes ppontes requested a review from a team as a code owner April 14, 2023 21:18
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 14, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 14, 2023
@ppontes ppontes force-pushed the cherry-pick/22-x-y/v8/f4b66ae451c2 branch from 4c485f5 to 93dbfdd Compare April 14, 2023 21:25
@MarshallOfSound MarshallOfSound merged commit 69d1434 into 22-x-y Apr 16, 2023
9 checks passed
@MarshallOfSound MarshallOfSound deleted the cherry-pick/22-x-y/v8/f4b66ae451c2 branch April 16, 2023 04:20
@release-clerk
Copy link

release-clerk bot commented Apr 16, 2023

Release Notes Persisted

Security: backported fix for 1427388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants