Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit context-menu event from extensions #38029

Merged
merged 1 commit into from Apr 27, 2023
Merged

feat: emit context-menu event from extensions #38029

merged 1 commit into from Apr 27, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Apr 19, 2023 •
edited

Description of Change

This PR surfaces context menu handling from extensions. This means that, among other thing, developers can now create context menus for PDF documents.

Checklist

Release Notes

Notes: Surface the context-menu event from extensions.

@codebytere codebytere added the semver/minor backwards-compatible functionality label Apr 19, 2023
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Apr 19, 2023
@codebytere codebytere marked this pull request as ready for review April 20, 2023 10:26
@codebytere codebytere requested a review from zcbenz April 24, 2023 10:14
@codebytere codebytere added the target/25-x-y PR should also be added to the "25-x-y" branch. label Apr 24, 2023
zcbenz
zcbenz approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere force-pushed the expose-mime-handler-context-menu branch from ddee7d9 to 3576bf1 Compare April 25, 2023 13:08
@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label Apr 26, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/approved ✅ and removed new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Apr 26, 2023
@codebytere codebytere merged commit ba8887f into main Apr 27, 2023
15 of 16 checks passed
@codebytere codebytere deleted the expose-mime-handler-context-menu branch April 27, 2023 10:54
@release-clerk
Copy link

release-clerk bot commented Apr 27, 2023

Release Notes Persisted

Surface the context-menu event from extensions.

@trop
Copy link
Contributor

trop bot commented Apr 27, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Apr 27, 2023
@codebytere
Copy link
Member Author

/trop run backport-to 25-x-y

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 25-x-y!

@trop trop bot mentioned this pull request May 17, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 17, 2023

I have automatically backported this PR to "25-x-y", please check out #38356

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed needs-manual-bp/25-x-y labels May 17, 2023
@trop trop bot removed the in-flight/25-x-y label May 18, 2023
@commit-lint commit-lint bot mentioned this pull request Jul 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
api-review/approved ✅ merged/25-x-y PR was merged to the "25-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @zcbenz