Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings #38035

Merged
merged 2 commits into from Apr 23, 2023

Conversation

quanglam2807
Copy link
Contributor

Description of Change

WebUSB API (added with #36289) docs and Typescript typings are not correct.

References:

CC: @jkleinsc

Checklist

Release Notes

Notes: Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings

@welcome
Copy link

welcome bot commented Apr 19, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Apr 19, 2023
@quanglam2807 quanglam2807 changed the title docs: Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings Apr 19, 2023
@dsanders11
Copy link
Member

Thanks for the PR! From the referenced code lines (very helpful), it looks like 'usb-device-added' and 'usb-device-removed' should also have WebContents as an additional parameter?

@codebytere codebytere added the target/25-x-y PR should also be added to the "25-x-y" branch. label Apr 20, 2023
@quanglam2807
Copy link
Contributor Author

Thanks, @dsanders11. I've updated it.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 20, 2023
@codebytere codebytere merged commit b626be5 into electron:main Apr 23, 2023
14 checks passed
@release-clerk
Copy link

release-clerk bot commented Apr 23, 2023

Release Notes Persisted

Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings

@welcome
Copy link

welcome bot commented Apr 23, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@trop
Copy link
Contributor

trop bot commented Apr 23, 2023

I have automatically backported this PR to "25-x-y", please check out #38095

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/25-x-y labels Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants