New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings #38035
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Thanks for the PR! From the referenced code lines (very helpful), it looks like |
Thanks, @dsanders11. I've updated it. |
Release Notes Persisted
|
Congrats on merging your first pull request! 🎉🎉🎉 |
I have automatically backported this PR to "25-x-y", please check out #38095 |
Description of Change
WebUSB API (added with #36289) docs and Typescript typings are not correct.
References:
usb-device-added
:electron/shell/browser/usb/usb_chooser_controller.cc
Line 72 in f12e12b
usb-device-removed
:electron/shell/browser/usb/usb_chooser_controller.cc
Line 81 in f12e12b
usb-device-revoked
:electron/shell/browser/usb/usb_chooser_context.cc
Line 211 in f12e12b
CC: @jkleinsc
Checklist
Release Notes
Notes: Fix 'usb-device-added', 'usb-device-removed', 'usb-device-revoked' typings