fix: defaults broken in shell.openExternal() options

[miniak]

Description of Change

When calling shell.openExternal('https://example.com/'); it parses activate as true correctly.
However calling shell.openExternal('https://example.com/', {}); would parse activate as false.

Related to:

electron/shell/common/gin_helper/dictionary.h

Lines 34 to 50 in 0240f66

	// Differences from the Get method in gin::Dictionary:
	// 1. This is a const method;
	// 2. It checks whether the key exists before reading;
	// 3. It accepts arbitrary type of key.
	template <typename K, typename V>
	bool Get(const K& key, V* out) const {
	// Check for existence before getting, otherwise this method will always
	// returns true when T == v8::Local<v8::Value>.
	v8::Local<v8::Context> context = isolate()->GetCurrentContext();
	v8::Local<v8::Value> v8_key = gin::ConvertToV8(isolate(), key);
	v8::Local<v8::Value> value;
	v8::Maybe<bool> result = GetHandle()->Has(context, v8_key);
	if (result.IsJust() && result.FromJust() &&
	GetHandle()->Get(context, v8_key).ToLocal(&value))
	return gin::ConvertFromV8(isolate(), value, out);
	return false;
	}

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed broken defaults in shell.openExternal() options.

[release-clerk]

Release Notes Persisted

Fixed broken defaults in shell.openExternal() options.

[trop]

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "22-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "25-x-y", please check out #38071

[trop]

I have automatically backported this PR to "24-x-y", please check out #38072

[trop]

@miniak has manually backported this PR to "23-x-y", please check out #38091

[trop]

@miniak has manually backported this PR to "22-x-y", please check out #38092