Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 2b30a50d0e62 from chromium #38058

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 21, 2023

[M112] Use ScriptState::Scope instead of setting HandleScope.

Since GetEffectiveFunction may call Get if the given v8 listener is
an object, we need to prepare v8::Context::Scope before calling it.
Blink already have a helper class to prepare the environment for the
script execution, which has already been used used in other
ServiceWorkerGlobalScope member functions. It is ScriptState::Scope
This CL also use it instead.

(cherry picked from commit 299385e09d41d5ce3abd434879b5f9b0a8880cd7)

Bug: 1429197
Change-Id: Idbcfdfa9c06160a18b57155a9540f72eed4ec0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4387655
Commit-Queue: Yoshisato Yanagisawa yyanagisawa@chromium.org
Commit-Queue: Kouhei Ueno kouhei@chromium.org
Reviewed-by: Leszek Swirski leszeks@chromium.org
Auto-Submit: Yoshisato Yanagisawa yyanagisawa@chromium.org
Reviewed-by: Kouhei Ueno kouhei@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1125148}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4411454
Reviewed-by: Shunya Shishido sisidovski@chromium.org
Cr-Commit-Position: refs/branch-heads/5615@{#1191}
Cr-Branched-From: 9c6408ef696e83a9936b82bbead3d41c93c82ee4-refs/heads/main@{#1109224}

Ref electron/security#314

Notes: Security: backported fix for CVE-2023-2133.

@ppontes ppontes requested a review from a team as a code owner April 21, 2023 14:11
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 21, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 21, 2023
@ppontes ppontes marked this pull request as draft April 21, 2023 14:11
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/2b30a50d0e62 branch from 00f11e0 to 59debe6 Compare April 21, 2023 22:10
@ppontes ppontes marked this pull request as ready for review April 21, 2023 22:10
@codebytere codebytere merged commit 518d3e4 into 22-x-y Apr 24, 2023
9 checks passed
@codebytere codebytere deleted the cherry-pick/22-x-y/chromium/2b30a50d0e62 branch April 24, 2023 12:25
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2023

Release Notes Persisted

Security: backported fix for CVE-2023-2133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants