Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f098ff0d1230 from chromium #38060

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 21, 2023

[m112] Retain DevToolsAgentHost after ForceDetachAllSessions()

(cherry picked from commit 8c4aee2a90d08535cfb1bf0a59e00cae956b1762)

Bug: 1424337
Change-Id: Ie0ebe2a49ffbd2356b896c39446b93e09cd81f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4378100
Reviewed-by: Dmitry Gozman dgozman@chromium.org
Commit-Queue: Andrey Kosyakov caseq@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1123772}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420271
Commit-Queue: Srinivas Sista srinivassista@chromium.org
Cr-Commit-Position: refs/branch-heads/5615@{#1244}
Cr-Branched-From: 9c6408ef696e83a9936b82bbead3d41c93c82ee4-refs/heads/main@{#1109224}

Ref electron/security#316

Notes: Security: backported fix for CVE-2023-2135.

@ppontes ppontes requested a review from a team as a code owner April 21, 2023 14:13
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 21, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 21, 2023
@ppontes ppontes marked this pull request as draft April 21, 2023 14:13
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/f098ff0d1230 branch from e1945b5 to d99c730 Compare April 21, 2023 22:23
@ppontes ppontes marked this pull request as ready for review April 21, 2023 22:23
miniak
miniak previously requested changes Apr 23, 2023
Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds are failing

@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/f098ff0d1230 branch from 6fa1bba to 8227517 Compare April 24, 2023 13:51
@ppontes ppontes force-pushed the cherry-pick/22-x-y/chromium/f098ff0d1230 branch from 8227517 to a8b007e Compare April 24, 2023 13:52
@ppontes
Copy link
Member Author

ppontes commented Apr 24, 2023

builds are failing

Fixed. CC: @miniak

@codebytere codebytere dismissed miniak’s stale review April 25, 2023 09:45

Failing builds addressed.

@codebytere codebytere merged commit 6820094 into 22-x-y Apr 26, 2023
9 checks passed
@codebytere codebytere deleted the cherry-pick/22-x-y/chromium/f098ff0d1230 branch April 26, 2023 08:11
@release-clerk
Copy link

release-clerk bot commented Apr 26, 2023

Release Notes Persisted

Security: backported fix for CVE-2023-2135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants