Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 8421a9eebd8a and 4dc670a8c557 from skia #38066

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 21, 2023

Reland "Enforce program stack limits on function parameters."

This reverts commit f5715362aac554ff3108b9e2a56b8ac8a6ef1acb.

Original change's description:

Revert "Enforce program stack limits on function parameters."

This reverts commit fa089d61014b77048daddb89300a3ab7cdf601bf.

Original change's description:

Enforce program stack limits on function parameters.

Previously, a function's parameter list did not count against its
stack size limit.

Bug: chromium:1432603
Change-Id: If49dce98f3155f3144a766c26b5a3a39401ce1b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/670236
Auto-Submit: John Stiles johnstiles@google.com
Commit-Queue: John Stiles johnstiles@google.com
Reviewed-by: Kevin Lubick kjlubick@google.com
Reviewed-by: Nicolette Prevost nicolettep@google.com
(cherry picked from commit 4dc748f14c6650cb45c7086a39af1760bfda41d2)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/670339
Reviewed-by: John Stiles johnstiles@google.com

Bug: chromium:1432603
Change-Id: I44439362f560200e30e6eeb56a86b0f84ee2a930
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671176
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Auto-Submit: John Stiles johnstiles@google.com
Commit-Queue: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com

Bug: chromium:1432603
Change-Id: I953efbba3d5b004e213571a04bd4f3ad68c663b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671876
Reviewed-by: Kevin Lubick kjlubick@google.com
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Commit-Queue: John Stiles johnstiles@google.com

============

Enforce size limits on struct and array declarations.

This improves error reporting by more clearly attaching the error
message to the oversized type.

Bug: chromium:1432603
Change-Id: I26511f08aff22072cf4913abf7be2c49940a732c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671377
Reviewed-by: Ben Wagner bungeman@google.com
Commit-Queue: John Stiles johnstiles@google.com
(cherry picked from commit 1cbd33ecd73523f8d4bf88e9c5576303b39e5556)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/671686
Reviewed-by: Brian Osman brianosman@google.com
Reviewed-by: John Stiles johnstiles@google.com

Notes: Security: backported fix for CVE-2023-2136.

@ppontes ppontes requested a review from a team as a code owner April 21, 2023 14:21
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 22-x-y labels Apr 21, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 21, 2023
@ppontes ppontes marked this pull request as draft April 21, 2023 14:21
@ppontes ppontes force-pushed the cherry-pick/22-x-y/skia/9e1af6fa14ff branch from 5c3e94e to 3ae00bb Compare April 21, 2023 21:45
@ppontes ppontes changed the title chore: cherry-pick 9e1af6fa14ff from skia chore: cherry-pick 8421a9eebd8a and 4dc670a8c557 from skia Apr 21, 2023
@ppontes ppontes marked this pull request as ready for review April 21, 2023 21:46
@codebytere codebytere merged commit 4c435b2 into 22-x-y Apr 23, 2023
11 checks passed
@codebytere codebytere deleted the cherry-pick/22-x-y/skia/9e1af6fa14ff branch April 23, 2023 20:54
@release-clerk
Copy link

release-clerk bot commented Apr 23, 2023

Release Notes Persisted

Security: backported fix for CVE-2023-2136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants