fix: crash on missing RenderWidgetHostView
#38100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
RenderWidgetHostView
codebytere
added
semver/patch
codebytere
force-pushed
the
handle-maybe-no-wc
branch
from
04cf758
to
5f7a6fc
Compare
codebytere
changed the title
RenderWidgetHostViewRenderWidgetHostView
VerteDinde
approved these changes
Apr 24, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "25-x-y", please check out #38115 |
trop
bot
added
in-flight/25-x-y
merged/25-x-y
|
/trop run backport-to 24-x-y |
|
@felixrieseberg is not authorized to run PR backports. |
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Apr 28, 2023
chore: fix crash on missing RenderWidgetHostView
|
@felixrieseberg has manually backported this PR to "24-x-y", please check out #38136 |
jkleinsc
pushed a commit
that referenced
this pull request
May 1, 2023
fix: crash on missing `RenderWidgetHostView` (#38100) chore: fix crash on missing RenderWidgetHostView Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Discovered while investigating #37453.
Fixes a potential crash when right-clicking on macOS windows with draggable regions. This can happen if for example the main window never loads content - we need to guard for missing
RenderWidgetHostView.Checklist
npm testpassesRelease Notes
Notes: Fixed a potential crash when right-clicking on macOS windows with draggable regions.